Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show restartCount for events #283

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

nilsgstrabo
Copy link
Contributor

No description provided.

@nilsgstrabo nilsgstrabo requested a review from satr April 23, 2021 12:15
@@ -104,7 +104,7 @@ const PageReplica = (props) => {
</React.Fragment>
)}
{selectedReplica &&
selectedReplica.restartCount != NaN &&
Number.isNaN(selectedReplica.restartCount) &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be !Number.isNaN(selectedReplica.restartCount) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. Good catch!

@nilsgstrabo nilsgstrabo merged commit 315fa24 into master Apr 23, 2021
@emirgens emirgens deleted the 88889-fix-replicacount-not-showing branch August 20, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants