Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pipeline-jobs page #297

Merged
merged 1 commit into from
Jun 25, 2021
Merged

update pipeline-jobs page #297

merged 1 commit into from
Jun 25, 2021

Conversation

Pespiri
Copy link
Contributor

@Pespiri Pespiri commented Jun 25, 2021

No description provided.

@Pespiri Pespiri requested a review from oterno June 25, 2021 08:48
Comment on lines 2 to 3
import { faCog, faQuestionCircle } from '@fortawesome/free-solid-svg-icons';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused imports

Comment on lines +15 to +16
min-width: 175px;
height: 68px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use padding and eds spacing variables

Comment on lines +4 to +12

nav.pipeline-jobs__breadcrumbs {
margin-bottom: 58px;
}

a.pipeline-jobs__create-btn {
height: 48px;
width: 137px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use padding/margin and eds spacing variables

@Pespiri Pespiri merged commit 09a14ed into main Jun 25, 2021
@Pespiri Pespiri deleted the 105788-update-Pipeline-Jobs-page branch June 25, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants