Raise a warning if multiple plugins exist with same name #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoakimJohansen
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
|
@anders-kiaer , can we please have a review, evt. approval by the end of "hacktoberfestivus"? |
There was a problem hiding this comment.
@antoneskov, @JoakimJohansen et al. - thanks for the PR 🎉 👏 Love the tests. 🤖
We will get this in (if that is enough feedback wrt. "hacktoberfestivus"), but would need some small changes before ready for merge to master.
Added some feedback as comments below. Also CI requires running black on the changed files to make it happy 🕵️♂️ If you don't have time I can also do the necessary changes, but that might be first next week.
|
Requested changes has been made @anders-kiaer. |
anders-kiaer
changed the title
|
@asnyv and/or @HansKallekleiv: 🟢 lights. This is ready for final review now from one of you. |
HansKallekleiv
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert a description of your pull request (PR) here, and check off the boxes below when they are done.
##hacktoberfestivus
Gives warning if multiple plugins exist with same name in different packages, along with the conflicting package names.
Contributors: The GreenTeam w/
torgeha
JoakimJohansen
antoneskov
Contributor checklist
CHANGELOG.md, and added it if should be communicated there.