Made single node selection more obvious #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenthoms
force-pushed
the
SmartNodeSelector-single-selection
branch
from
56a46b7
to
ad05ba4
Compare
rubenthoms
force-pushed
the
SmartNodeSelector-single-selection
branch
from
ad05ba4
to
ef6c246
Compare
|
👍 Good suggestion on changing the renderer when single node is to be selected, and I see this probably becomes immediately valuable to e.g. @jorgenherje and the calculator component. LGTM. |
jorgenherje
approved these changes
May 19, 2021
rubenthoms
force-pushed
the
SmartNodeSelector-single-selection
branch
from
ef6c246
to
d5fc9e6
Compare
rubenthoms
force-pushed
the
SmartNodeSelector-single-selection
branch
from
d5fc9e6
to
e2745bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when allowing only a single node to be selected, the selector was still rendered as if several nodes could be selected. This was using unnecessary much space and could be confusing for the user. This PR makes the single node selection more obvious by changing how the selector is rendered.