All tags (also invalid or duplicate ones, but no empty strings) are send to parent in SmartNodeSelector.
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenthoms
changed the title
SmartNodeSelector.SmartNodeSelector.
anders-kiaer
approved these changes
May 4, 2021
rubenthoms
force-pushed
the
adjust-selected-tags-in-smartnodeselector
branch
from
c6f53c8
to
51b64dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, only valid, non-duplicate tags were sent to the parent component via the
selectedTagsargument in thesetPropsfunction call. This made it hard for parent components that updated states (and caused rerenderings) based on thesetPropscalls fromSmartNodeSelectorto keep the state of theSmartNodeSelector's selection. For example, a click on the switch button in a tag could select a node which lacks the last sub node of the previous selection, causing the selected node to become invalid. However, the parent'ssetPropsfunction would be called withselectedTagsmissing this now invalidated tag. If theSmartNodeSelectorcomponent gets rerendered, this invalid selected tag would most likely get lost, causing incomprehensible behaviour. Sending all tags, even invalid ones, but as before only valid nodes and ids should help to overcome this potential problem.