Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added feedback button to WebvizPluginPlaceholder. #130

Merged
merged 3 commits into from
May 19, 2021
Merged

Added feedback button to WebvizPluginPlaceholder. #130

merged 3 commits into from
May 19, 2021

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented May 10, 2021 •
edited
Loading

Added href and target properties to WebvizToolbarButton.

Closes #127.

@rubenthoms
Added feedback button to WebvizPluginPlaceholder.
b995800 
Added `href` and `target` properties to `WebvizToolbarButton`.
@rubenthoms rubenthoms mentioned this pull request May 10, 2021
Merged
anders-kiaer
anders-kiaer approved these changes May 11, 2021
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 🍰

@rubenthoms rubenthoms merged commit 182cbd8 into equinor:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Webviz
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Report issue/improvement suggestion" button
2 participants
@rubenthoms @anders-kiaer