Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartNodeSelector: Several bug fixes #136

Merged
merged 8 commits into from
Jun 3, 2021

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Jun 2, 2021

Bug fixes

  • Exception on entering invalid node name when no metadata given
  • Exception on using multiple wildcards (e.g. *:*:*:*)
  • When pressing enter with single node selection and invalid data, a new tag is added
  • When node name is partly contained in others, the node is selected several times
  • Crash when holding backspace pressed
  • Focus overlay position could be off

Changes

  • Changes to selected tags are always sent to parent

Fixes #135.

- Exception on entering invalid node name when no metadata given
- Exception on using wildcards
- Bug fix: when pressing enter with single node selection and invalid data
- Bug fix: when node name is partly contained in others, the node is selected several times
@rubenthoms rubenthoms changed the title Several bug fixes SmartNodeSelector: Several bug fixes Jun 2, 2021
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testes on teams video chat.

Functionality works and verified by usage in VectorCalculator.

@rubenthoms rubenthoms merged commit da950fe into equinor:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SmartNodeSelector: Bug when pressing enter in single node selection with invalid tag
3 participants