SmartNodeSelector : Extended property state updates
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
225
to
226
| let hasError = false; | ||
| let error = ""; |
There was a problem hiding this comment.
Suggested change
| let hasError = false; | |
| let error = ""; | |
| let error; |
CHANGELOG.md
Outdated
| - [#140](https://github.com/equinor/webviz-core-components/pull/140) - Improved styling of the `Select` component. | ||
| - [#145](https://github.com/equinor/webviz-core-components/pull/145) - Added wrapper components for typically used Dash components (Dropdown, Slider, etc) with additional styling. | ||
| - [#148](https://github.com/equinor/webviz-core-components/pull/148) - Changed default value of `numSecondsUntilSuggestionsAreShown` to 0.5 in `SmartNodeSelector` component. | ||
| - [#151](https://github.com/equinor/webviz-core-components/pull/151) - `SmartNodeSelector`: Changes to `data` and `delimiter` props are considered now and cause the component to update. |
There was a problem hiding this comment.
There were quite some changes to this file. Change to only adding the 151-entry, and instead consider if we want to enforce further style rules on CHANGELOG.md in separate issue/PR?
| }); | ||
| } catch (e) { | ||
| this.treeData = null; | ||
| hasError = true; |
There was a problem hiding this comment.
Suggested change
| hasError = true; |
Comment on lines
249
to
248
| hasError: hasError, | ||
| error: error, |
There was a problem hiding this comment.
Suggested change
| hasError: hasError, | |
| error: error, | |
| hasError: error !== undefined, | |
| error: error || "", |
Changes to `data` and `delimiter` are considered now.
rubenthoms
force-pushed
the
extend-property-state-updates
branch
from
8178c01
to
c55287b
Compare
Adjusted changelog format
anders-kiaer
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
dataanddelimiterare considered now and cause the component to update.