Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted propTypes of PluginPlaceholder to avoid error messages #158

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Adjusted propTypes of PluginPlaceholder to avoid error messages #158

merged 2 commits into from
Sep 9, 2021

Conversation

rubenthoms
Copy link
Collaborator

Fixes #155.

@rubenthoms rubenthoms self-assigned this Sep 8, 2021
anders-kiaer
anders-kiaer approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🐛

Add a ### Fixed section to the last changelog entries?

@rubenthoms rubenthoms force-pushed the EQ_155-placeholder-property-adjustments branch from 0b2a21d to 20eaf9f Compare September 9, 2021 07:24
@rubenthoms rubenthoms merged commit a51f889 into master Sep 9, 2021
@rubenthoms rubenthoms deleted the EQ_155-placeholder-property-adjustments branch September 9, 2021 08:06
@anders-kiaer anders-kiaer mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anders-kiaer anders-kiaer anders-kiaer approved these changes

Assignees

@rubenthoms rubenthoms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contact_person.name in WebvizPluginPlaceholder is required but it was not provided
2 participants
@rubenthoms @anders-kiaer