Feature: Render popup at window level #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rubenthoms
commented
Oct 18, 2021
•
rubenthoms
commented
- Suggestions popup renders now at top level.
- Improved bug with displaying browse buttons at center (dependent on size) - this is not completely fixed yet (and cannot be) until a more advanced logic for dealing with long node names is implemented, see SmartNodeSelector: Use ellipsis to shorten (too) long node paths (tags) #132.
jorgenherje
requested changes
Oct 19, 2021
react/src/lib/components/SmartNodeSelector/components/Suggestions.css
Outdated
Show resolved
Hide resolved
jorgenherje
requested changes
Oct 19, 2021
react/src/lib/components/SmartNodeSelector/components/Suggestions.tsx
Outdated
Show resolved
Hide resolved
rubenthoms
force-pushed
the
EQ_180-several-bug-fixes-in-sns
branch
from
55b1962
to
48e203f
Compare
jorgenherje
approved these changes
Oct 20, 2021
- Improved bug with displaying browse buttons at center (dependent on size)
Disabled suggestions test since it is not working with globally attached elements.
rubenthoms
force-pushed
the
EQ_180-several-bug-fixes-in-sns
branch
from
f5002d2
to
3c5aaa2
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.