Enforce engine versions and avoid install scripts #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-kiaer
added
maintenance
next release 🚢
rubenthoms
approved these changes
Aug 25, 2022
| @@ -0,0 +1,2 @@ | |||
| engine-strict=true | |||
| ignore-scripts=true | |||
There was a problem hiding this comment.
When including this, we should make sure that no packages require to run scripts in order to work. As of now, we don't have any packages requiring this, but we should make sure we don't install any. Maybe we could make use of https://github.com/dominykas/allow-scripts? The question is then how we can whitelist packages? npm does not support anything like that yet.
anders-kiaer
force-pushed
the
enforceversion
branch
from
a1baa35
to
44ba3ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.