-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WLF
and Menu
: Storing of states
#240
Merged
rubenthoms
merged 12 commits into
equinor:master
from
CeetronSolutions:WLF-keep-settings-open
Aug 25, 2022
Merged
WLF
and Menu
: Storing of states
#240
rubenthoms
merged 12 commits into
equinor:master
from
CeetronSolutions:WLF-keep-settings-open
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented storing of required information and
Fixes equinor/webviz-config#605. |
HansKallekleiv
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Moved drawer open state to global state store.
Pointer events removed from settings groups when closed
jorgenherje
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Tested and verified 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces storing of
WLF
(active plugin, active view, settings drawer toggle state, opened settings groups) andMenu
(open settings group which contains current page when initially loading) states in the browser's local storage. Moreover, if no URL path is given, the first page of the Webviz app is automatically opened.Last but not least, settings groups do now remain open when other groups are toggled (independent state).