Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debounce time for wcc.Select #243

Merged

Conversation

jorgenherje
Copy link
Collaborator

Add debounce time for wcc.Select. Will prevent firing selected values immediately, for unwanted callback triggering.

Debounce time can be configured - default value is 500 ms.


Closes: #195

@jorgenherje jorgenherje added the enhancement New feature or request label Aug 24, 2022
@jorgenherje jorgenherje self-assigned this Aug 24, 2022
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two changes to consider, two bugs to fix.

react/src/lib/components/Select/Select.tsx Outdated Show resolved Hide resolved
react/src/lib/components/Select/Select.tsx Outdated Show resolved Hide resolved
react/src/lib/components/Select/Select.tsx Outdated Show resolved Hide resolved
react/src/lib/components/Select/Select.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@rubenthoms rubenthoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rubenthoms rubenthoms merged commit 00a2dd0 into equinor:master Aug 30, 2022
rubenthoms added a commit that referenced this pull request Aug 30, 2022
jorgenherje added a commit that referenced this pull request Aug 30, 2022
@rubenthoms
Copy link
Collaborator

This PR had to be reverted since the new functionality the Select component broke other Webviz applications. We have to perform a more thorough investigation of why this happened, adjust the changes to the component accordingly, and create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

Add delay/debounce time for wcc.Select-component
2 participants