Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing id and key props #248

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Added missing id and key props #248

merged 2 commits into from
Sep 6, 2022

Conversation

rubenthoms
Copy link
Collaborator

Added id to SettingsGroup and key to WebivzViewList__Group. This is especially important for opening settings groups in Python tests.

@rubenthoms rubenthoms added the enhancement New feature or request label Sep 5, 2022
@rubenthoms rubenthoms self-assigned this Sep 5, 2022
@rubenthoms rubenthoms mentioned this pull request Sep 5, 2022
Merged
@rubenthoms rubenthoms merged commit 49dfd5e into equinor:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgenherje jorgenherje jorgenherje approved these changes

Assignees

@rubenthoms rubenthoms

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubenthoms @jorgenherje