-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored ScrollArea
component
#265
Refactored ScrollArea
component
#265
Conversation
Using native scroll mechanisms with a modern layout and touch support Fixes issues with scrolling `ScrollArea` even though only child container should have been scrolled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Tested and works well 👍
Just a couple of minor comments/suggestions regarding temporary code, naming and readability of calculations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Closes #262 |
Now using native scroll mechanisms with a modern layout and touch support.
Fixes issues with scrolling
ScrollArea
even though only child container (e.g.wcc.Select
orwcc.Dropdown
popup) should have been scrolled.