Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored ScrollArea component #265

Merged
merged 15 commits into from
Sep 29, 2022

Conversation

rubenthoms
Copy link
Collaborator

Now using native scroll mechanisms with a modern layout and touch support.

Fixes issues with scrolling ScrollArea even though only child container (e.g. wcc.Select or wcc.Dropdown popup) should have been scrolled.

Using native scroll mechanisms with a modern layout and touch support
Fixes issues with scrolling `ScrollArea` even though only child container should have been scrolled
@rubenthoms rubenthoms added the bug Something isn't working label Sep 22, 2022
@rubenthoms rubenthoms self-assigned this Sep 22, 2022
@rubenthoms rubenthoms marked this pull request as draft September 23, 2022 07:47
@rubenthoms rubenthoms marked this pull request as ready for review September 26, 2022 14:01
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested and works well 👍

Just a couple of minor comments/suggestions regarding temporary code, naming and readability of calculations.

react/src/lib/components/ScrollArea/ScrollArea.tsx Outdated Show resolved Hide resolved
react/src/lib/components/ScrollArea/ScrollArea.tsx Outdated Show resolved Hide resolved
react/src/lib/components/ScrollArea/ScrollArea.tsx Outdated Show resolved Hide resolved
react/src/lib/components/ScrollArea/ScrollArea.tsx Outdated Show resolved Hide resolved
react/src/lib/components/ScrollArea/ScrollArea.tsx Outdated Show resolved Hide resolved
react/src/demo/App.tsx Outdated Show resolved Hide resolved
@rubenthoms rubenthoms added the next release 🚢 To be included in next release label Sep 29, 2022
Copy link
Collaborator

@jorgenherje jorgenherje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@rubenthoms rubenthoms merged commit 3b7a1fa into equinor:master Sep 29, 2022
@rubenthoms
Copy link
Collaborator Author

rubenthoms commented Jan 10, 2023

Closes #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next release 🚢 To be included in next release
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

2 participants