-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AHM analysis plugin #478
AHM analysis plugin #478
Conversation
Thanks for the PR @mareco701. 🎉 Changed the status of this to "draft" while waiting for things to go 🟢. Looks like a module is currently missing according to the logs? |
Looks good 👍 Changing temporarily these lines webviz-subsurface/.github/workflows/subsurface.yml Lines 83 to 86 in 5f5dc65
mareco701 and inc_test_for_ahmanalysis would help in the last part of the review process by automatically testing against your new testdata PR (then we simply change those two lines back before merge ).
|
This looks ready for review now @mareco701 👍 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice plugin @mareco701.
Give path to input data:
Should we remove this input box in the frontend, since it is already defined in the yaml
file? In addition asking for file input will not work very well in ☁️ setting. Then you can also simplify the callback logic (everything related to input file changing).
Show default parameters distribution
Show transformed parameters distribution (if available)
Then maybe at plugin startup you already know if the transformed distribution is available, and can hide (or disable/grey out) this option in order to simplify the UI? Since it is binary choice (default or transformed) maybe it can be a check box instead of two radio buttons?
Add a guided tour explaining what the usersees? See
def tour_steps(self): |
{element_id: "Your description of the element"}
and Webviz framework will take it from there.
Filter observations:
Filter parameters:
Maybe they should use e.g. wcc.Select
instead of text input box? Both to make it easier to select among other options, and to ensure only valid options are entered (currently writing an non-existing parameter in the parameter filter results in an IndexError
). See https://webviz-subsurface-example.azurewebsites.net/parameter-parallel-coordinates for an example using wcc.Select
.
Co-authored-by: Anders Fredrik Kiær <[email protected]>
…urface into ahmanalysis_plugin
… code in _ahm_analysis_plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
This is to add a new plugin to visualize assisted history matching analysis (how much update in parameters observations trigger, and which observations trigger an update of a parameter when all observations are considered)
Contributor checklist
CHANGELOG.md
, and added it if should be communicated there.