Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to SurfaceViewerFMU #526

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Minor fixes to SurfaceViewerFMU #526

merged 1 commit into from
Dec 18, 2020

Conversation

HansKallekleiv
Copy link
Collaborator

@HansKallekleiv HansKallekleiv commented Dec 10, 2020 •
edited
Loading

Contributor checklist

  • 🎉 This PR closes Update documentation for SurfaceViewerFMU #517, User specified map units not displayed in SurfaceViewerFMU #525 .
  • 📜 I have broken down my PR into the following tasks:
    • Improve missing documentation for changes introduced with new map component
    • Show user configured map unit
    • Set default displayed map unit to empty string
    • Allow user to set map height
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

@HansKallekleiv HansKallekleiv self-assigned this Dec 10, 2020
@HansKallekleiv HansKallekleiv added this to the Week 50-52 milestone Dec 10, 2020
@HansKallekleiv HansKallekleiv force-pushed the surface-fixes branch 2 times, most recently from 8f3a43a to 2be627c Compare December 18, 2020 08:36
@HansKallekleiv HansKallekleiv marked this pull request as ready for review December 18, 2020 08:36
asnyv
asnyv approved these changes Dec 18, 2020
View reviewed changes
Copy link
Collaborator

@asnyv asnyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@HansKallekleiv HansKallekleiv merged commit 4a30507 into equinor:master Dec 18, 2020
@HansKallekleiv HansKallekleiv deleted the surface-fixes branch December 18, 2020 09:15
@asnyv asnyv mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnyv asnyv asnyv approved these changes

@anders-kiaer anders-kiaer Awaiting requested review from anders-kiaer

Assignees

@HansKallekleiv HansKallekleiv

Labels
None yet
Projects
Webviz
Archived in project
Milestone
Week 50-52
Development

Successfully merging this pull request may close these issues.

Update documentation for SurfaceViewerFMU
2 participants
@HansKallekleiv @asnyv