Improve table performance of AssistedHistoryMatchingAnalysis #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareco701
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
anders-kiaer
changed the title
anders-kiaer
requested changes
Apr 27, 2021
There was a problem hiding this comment.
Thanks @mareco701. I think we can take this in. I think we could benefit of some code restructureing in this plugin, but that is separate from this PR.
In addition to the comments below, could you add a new entry in ./CHANGELOG.md?
webviz_subsurface/plugins/_assisted_history_matching_analysis.py
Outdated
Show resolved
Hide resolved
webviz_subsurface/plugins/_assisted_history_matching_analysis.py
Outdated
Show resolved
Hide resolved
…ebviz-subsurface into ahmanalysis_pluginfixbigdata
|
I have updated the script and added a new entry in ./CHANGELOG.md. Please have a look to see if it is ok. |
anders-kiaer
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #611.