Wrote the tour_steps function and fixed some bugs in the docstring #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindjoha
requested review from
anders-kiaer,
asnyv and
HansKallekleiv
as code owners
anders-kiaer
approved these changes
Apr 29, 2021
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
…fixed bugs (equinor#626) * Adjusted `VectorSelector` and `VectorCalculator` to work with new `SmartNodeSelector`. * Added `updateFromWithin` check to `componentDidUpdate` * Fixed crash when removing first node. * Bug fix: dynamic changes to `customVectorDefinitions` not recognized * Set `webviz-core-components` version to `next`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed some bugs in the docstring and included a tour_steps method