Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eclipse volumes in VolumetricAnalysis #770

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Sep 20, 2021

Up until now the VolumetricAnalysis plugin has only supported static input. This PR fixes that issue.

The PR includes:

  • Automatic detection of what fluid_type the different volumetric files are (static vs dynamic)
    • if only dynamic files are given as input, no processing is performed in the InplaceVolumesModel (e.g. removal of column fluid suffixes and computation of properties from the volumetric data)
  • Validation of the static volume files as they must fit a strict format to be fit for the input processing done in the InplaceVolumesModel.
  • Utilization of the FipMapper from fmu.tools for creating sets of FIPNUM's and REGION∕ZONE's that are comparable
    in volumes, and combining volumes per set. To trigger this behaviour a fipfile with FIPNUM to REGION∕ZONE mapping information needs to be provided.

Also included in the PR:

  • Support for giving more than one csv as input to the different volumetric sources (files under each source are merged on common columns).
volfiles:
    geogrid:
        - geogrid_oil.csv
        - geogrid_gas.csv

Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Task 1
    • Task 2
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 I have considered adding a new entry in CHANGELOG.md, and added it if should be communicated there.

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'm not able to find much to comment on 👍

CHANGELOG.md Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@anders-kiaer anders-kiaer changed the title Support eclipse volumes in VolumetricAnalysis Support eclipse volumes in VolumetricAnalysis Sep 20, 2021
@tnatt tnatt merged commit 9621b0f into equinor:master Sep 21, 2021
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
* Linked well log views equinor#693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants