Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RftPlotter bug fixes and improvements #854

Merged
merged 18 commits into from
Nov 25, 2021

Conversation

lindjoha
Copy link
Collaborator

@lindjoha lindjoha commented Nov 24, 2021

The following are done in this PR:

@anders-kiaer anders-kiaer changed the title Rftplotter bug fixes and improvements RftPlotter bug fixes and improvements Nov 24, 2021
@anders-kiaer anders-kiaer added bug 🐛 Something isn't working maintenance next release 🚢 To be included in next release labels Nov 24, 2021
Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this has already been reviewed by @tnatt AFAIK ➡️ I have only one final comment and then we can merge IMO. 🙂

tests/integration_tests/plugin_tests/test_rft_plotter.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, LGTM 👍

@lindjoha lindjoha merged commit edfec8e into equinor:master Nov 25, 2021
@lindjoha lindjoha deleted the rftplotter_improvements branch January 5, 2022 13:03
VincentNevermore pushed a commit to VincentNevermore/webviz-subsurface that referenced this pull request Jul 19, 2022
* Added axes layer.

* Code comment fix.

* Moved experimental map layer story to last.

* Added axes story.

* Fixed layers spec in Axes story.

* Set default axis visibility to true.

Co-authored-by: Havard Bjerke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working maintenance next release 🚢 To be included in next release
Projects
Archived in project
3 participants