-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RftPlotter
bug fixes and improvements
#854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindjoha
requested review from
anders-kiaer,
asnyv,
HansKallekleiv and
tnatt
as code owners
November 24, 2021 09:11
anders-kiaer
changed the title
Rftplotter bug fixes and improvements
Nov 24, 2021
RftPlotter
bug fixes and improvements
anders-kiaer
added
bug 🐛
Something isn't working
maintenance
next release 🚢
To be included in next release
labels
Nov 24, 2021
lindjoha
force-pushed
the
rftplotter_improvements
branch
from
November 25, 2021 09:16
485f48e
to
0e46954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this has already been reviewed by @tnatt AFAIK ➡️ I have only one final comment and then we can merge IMO. 🙂
tnatt
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements, LGTM 👍
VincentNevermore
pushed a commit
to VincentNevermore/webviz-subsurface
that referenced
this pull request
Jul 19, 2022
* Added axes layer. * Code comment fix. * Moved experimental map layer story to last. * Added axes story. * Fixed layers spec in Axes story. * Set default axis visibility to true. Co-authored-by: Havard Bjerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following are done in this PR:
_layout.py
,_callbacks.py
and_business_logic.py