Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well analysis plugin #981

Merged
merged 40 commits into from
Mar 22, 2022
Merged

Well analysis plugin #981

merged 40 commits into from
Mar 22, 2022

Conversation

lindjoha
Copy link
Collaborator

@lindjoha lindjoha commented Mar 10, 2022

New plugin with well analysis visualizations. As a start there is one tab with different well production charts (bar chart, pie charts and stacked area chart). And there is one tab with well network analysis (WMCTL mode area chart and network pressures).


Contributor checklist

  • 🎉 This PR closes #ISSUE_NUMBER.
  • 📜 I have broken down my PR into the following tasks:
    • Well production visualizations
    • Well network analysis visualizations
  • 🤖 I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR.
  • 📖 Added entry in CHANGELOG.md

Copy link
Collaborator

@anders-kiaer anders-kiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work @lindjoha. I'm not able to find much to comment on at all.

This new addition is definitely worth adding a changelog entry 🎉

Question: Since we have the new gruptree_model.py, should this also at some point be used by e.g. the production network plugin?

webviz_subsurface/_models/gruptree_model.py Outdated Show resolved Hide resolved
webviz_subsurface/_utils/colors.py Show resolved Hide resolved
@anders-kiaer
Copy link
Collaborator

Nice, LGTM @lindjoha 👍 Let us merge this after equinor/webviz-subsurface-testdata#131 has been merged, and the GitHub workflow reverted.

@anders-kiaer anders-kiaer added the next release 🚢 To be included in next release label Mar 22, 2022
@lindjoha lindjoha merged commit 687a5b3 into equinor:master Mar 22, 2022
@lindjoha lindjoha deleted the well_analysis_plugin branch March 22, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release 🚢 To be included in next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants