Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-1953 Create Log Header Consistency Check #1976

Merged
merged 10 commits into from
Aug 7, 2023

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Jul 7, 2023

Fixes

This pull request fixes #1953

Description

API:

  • Created a route to get a job by its Id.
  • Added an optional jobId to WorkerResult so that the job info can be fetched when a job finishes.
  • Created a CheckLogHeader -Job and -Worker that checks if the log header is consistent.
  • Added a Report to JobInfo.
  • Created a CheckLogHeaderReport that includes all information needed to show mismatching log headers.
  • Tests.

Frontend:

  • Added Check Log Header button in logs' context menu.
  • Created a ReportModal to show reports.
  • Added a Component cell type for ContentTable for the Report button in the Jobs view.
  • Added a export as .csv button to Panel that can be used for any ContentTable.
  • Tests.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@eliasbruvik eliasbruvik marked this pull request as draft July 7, 2023 15:01
@eliasbruvik eliasbruvik marked this pull request as ready for review August 1, 2023 07:19
Copy link
Contributor

@janburak janburak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@janburak janburak merged commit 29b6e47 into equinor:main Aug 7, 2023
2 checks passed
@eliasbruvik eliasbruvik deleted the FIX-1953 branch August 28, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log Header Consistency Check
2 participants