Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-499 Add new mnemonics when importing log data #1988

Merged
merged 2 commits into from
Aug 7, 2023
Merged

FIX-499 Add new mnemonics when importing log data #1988

merged 2 commits into from
Aug 7, 2023

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Aug 2, 2023 •
edited
Loading

Fixes

This pull request fixes #499

Description

  • Add new mnemonics when importing log data.
  • Attempt an updateInStore twice if it fails the first time.
  • Remove unnecessary useEffects from LogDataImportModal.
  • Add information tooltip to show additional information.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

janburak
janburak approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@janburak janburak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@eliasbruvik eliasbruvik merged commit 05006a6 into equinor:main Aug 7, 2023
2 checks passed
@eliasbruvik eliasbruvik deleted the FIX-499 branch August 7, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janburak janburak janburak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 Create missing curves/mnemonic when importing CSV file
2 participants
@eliasbruvik @janburak