Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-1899 Curve data streaming #2050

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

eliasbruvik
Copy link
Contributor

@eliasbruvik eliasbruvik commented Sep 14, 2023

Fixes

This pull request fixes #1899, #478

Description

Implemented streaming of curve data:

  • Added logic in CurveValuesView to periodically look for new data.
    • When turning on streaming mode, the newest data of the log is fetched and replaces any current data.
      • This is done in case the selected range might not cover the end of the log, and in case the log has been updated before enabling stream mode.
      • When the end of the log is fetched, it starts looking for new data.
    • Delay between each call to the API can be changed in the UI.
  • Streaming is only enabled for growing logs.
  • Streaming works for both the table and the plot.
    • ContentTable shows new rows with a green color that fades back to normal.
    • The plot adds new data rows, but only shows the 300 last rows to avoid lag.
  • EditInterval is updated so it can be updated with the current start and end indexes.
    • It is also disabled while streaming.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

janmarius
janmarius previously approved these changes Oct 2, 2023
Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the PR, but recommend fixing the event type set to "any".

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

Copy link
Contributor

@janmarius janmarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer checklist

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@eliasbruvik eliasbruvik merged commit 8c8e1b3 into equinor:main Oct 2, 2023
4 checks passed
@eliasbruvik eliasbruvik deleted the FIX-1899 branch October 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open Channel stream for 1 or several timebased curves (streaming window)
2 participants