Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework EditInterval datetime input #1991 #2061

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Rework EditInterval datetime input #1991 #2061

merged 3 commits into from
Oct 2, 2023

Conversation

robertbasti
Copy link
Collaborator

@robertbasti robertbasti commented Sep 22, 2023 •
edited by eliasbruvik
Loading

Fixes

This pull request fixes

Description

date time selection pickers for EditInterval

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

eliasbruvik
eliasbruvik approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@robertbasti robertbasti merged commit 5d5a36e into equinor:main Oct 2, 2023
3 checks passed
@eliasbruvik eliasbruvik mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertbasti @eliasbruvik