Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-1918 Count number of rows in all curves #2075

Merged
merged 7 commits into from
Oct 16, 2023
Merged

FIX-1918 Count number of rows in all curves #2075

merged 7 commits into from
Oct 16, 2023

Conversation

jaroslavbliznak
Copy link
Contributor

Fixes

This pull request fixes #1918

Description

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

eliasbruvik
eliasbruvik requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks very good! Just added a few small suggestions for improvement.

Src/WitsmlExplorer.Frontend/components/ContextMenus/LogObjectContextMenu.tsx Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Workers/CountLogDataRowWorker.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Workers/CountLogDataRowWorker.cs Outdated Show resolved Hide resolved
Src/WitsmlExplorer.Api/Workers/CountLogDataRowWorker.cs Outdated Show resolved Hide resolved
eliasbruvik
eliasbruvik requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested some edge cases. It fails if you run the job on a log that has mnemonics, but none of the mnemonics have any values.

@jaroslavbliznak
Copy link
Contributor Author

It seems that the issue occurred when setting the StartIndex and EndIndex in the LogDataReader, where there were null indexes (StartIndex, EndIndex or StartDateTimeIndex, EndDateTimeIndex) for a specific log.

eliasbruvik
eliasbruvik approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@eliasbruvik eliasbruvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

@jaroslavbliznak jaroslavbliznak merged commit e31d7f1 into equinor:main Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliasbruvik eliasbruvik eliasbruvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Count number of rows in all curves of a log
2 participants
@jaroslavbliznak @eliasbruvik