Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-2045 BE-fix conditions, empty strings and using constants #2179

Merged
merged 2 commits into from
Dec 13, 2023
Merged

FIX-2045 BE-fix conditions, empty strings and using constants #2179

merged 2 commits into from
Dec 13, 2023

Conversation

jaroslavbliznak
Copy link
Contributor

Fixes

This pull request fixes #2045

Description

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@jaroslavbliznak jaroslavbliznak merged commit 5c82937 into equinor:main Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrlicman petrlicman petrlicman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use constants instead of magic numbers and strings, fix conditions and unboxing
2 participants
@jaroslavbliznak @petrlicman