FIX-2141 Wrong login error message on some servers #2233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
This pull request fixes #2141
Description
When a user enters incorrect login credentials on Petrolink servers, it currently returns an HTTP response status of 500(internal server error), but it should return an HTTP response status of 401(unauthorized). It should be change on Petrolink servers.
It added a new WitsmlRemoteServerRequestCrashedException, which will handle this "internal server error" and merge HTTP response statuses 401 and 403 into one MessageSecurityException.
Type of change
Impacted Areas in Application
Checklist:
Communication
Code quality
Test coverage
Further comments