Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2141 Wrong login error message on some servers #2233

Conversation

jaroslavbliznak
Copy link
Contributor

Fixes

This pull request fixes #2141

Description

When a user enters incorrect login credentials on Petrolink servers, it currently returns an HTTP response status of 500(internal server error), but it should return an HTTP response status of 401(unauthorized). It should be change on Petrolink servers.
It added a new WitsmlRemoteServerRequestCrashedException, which will handle this "internal server error" and merge HTTP response statuses 401 and 403 into one MessageSecurityException.

Type of change

  • Bugfix
  • New feature (non-breaking change which adds functionality)
  • Enhancement of existing functionality
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Impacted Areas in Application

  • Frontend
  • API
  • WITSML
  • Other (please describe)

Checklist:

Communication

  • I have made corresponding changes to the documentation
  • PR affects application security

Code quality

  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • New code is covered by passing tests

Further comments

@jaroslavbliznak jaroslavbliznak merged commit 9f47172 into equinor:main Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong login error message on some servers 🐛
2 participants