Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CurveValuesView.tsx #743

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

HakonHesselberg
Copy link
Collaborator

Request Template Witsml Explorer

Thank you for contributing to WITSML Explorer!
Before submitting this PR, please fill in the following template.

Fixes

This pull request helps clean up the code for working on #478.

Description

Pull code out of CurveValuesView and into tableParts

Type of change

  • Enhancement of existing functionality

Impacted Areas in Application

List general components of the application that this PR will affect:

  • CurveValuesView

Checklist:

Please tick all the boxes or remove the ones that aren't needed and explain why

Communication

  • PR is related to an issue

Code quality

  • Code follows the style guidelines
  • I have self-reviewed my code
  • No new warnings are generated

Test coverage

  • Existing tests pass

Copy link
Collaborator

@steinsiv steinsiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read issue and PR
  • Pulled branch and manually tested
  • Verify that PR resolves issue
  • Reviewed the code

Tested with NO 16_2-D-15-GMTime-BLOCKPOS on 53M logs working fine :)

@HakonHesselberg HakonHesselberg merged commit 140562b into equinor:main Oct 13, 2021
@HakonHesselberg HakonHesselberg deleted the RefactorCurveValueView branch October 13, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants