Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitsu #341

Closed
erengy opened this issue Nov 30, 2016 · 45 comments
Closed

Kitsu #341

erengy opened this issue Nov 30, 2016 · 45 comments

Comments

@erengy
Copy link
Owner

erengy commented Nov 30, 2016

Kitsu

Hummingbird is about to become Kitsu. This means that, within a couple of days, Taiga's Hummingbird service will stop working.

Since the new website brings about a different API, there's much more to be done than just replacing "Hummingbird" with "Kitsu" on Taiga's codebase. Also, a new version of Taiga should be able to automatically import local Hummingbird data for a smooth transition.

Unfortunately, I won't be around at Kitsu's launch to celebrate. But when I return home next week, I will start working on this issue and release a beta version as soon as possible.

@erengy
Copy link
Owner Author

erengy commented Dec 11, 2016

Progress report: Development is going on at the kitsu branch. It's not in a usable state yet, but most of the basic functionality is now implemented. Current plan is to release a beta version right after Kitsu's full launch and get feedback until the service can be considered stable.

@erengy
Copy link
Owner Author

erengy commented Dec 12, 2016

Hummingbird is now being migrated to Kitsu.

You may continue using Taiga in offline mode for a while, but you will start seeing errors if you try connecting to Hummingbird. To avoid some of these errors, I'd suggest disabling auto synchronization from Tools menu and the Synchronize automatically at startup option from SettingsServicesMain.

When Kitsu support is ready, I'll announce the download link for the beta version in here and in the forums.

@ShaunV2
Copy link

ShaunV2 commented Dec 12, 2016

@erengy Is there anyway you could make two versions of Taiga to support the services separately? Would that be possible?
Sorry if this isn't the right place to post this.

@sachaw
Copy link

sachaw commented Dec 13, 2016

Is there a point, You can turn either off easily, and maintaining 2 applications becomes a low of work.

@ShaunV2
Copy link

ShaunV2 commented Dec 13, 2016

Is there a point, you can turn either off easily, and maintaining 2 applications becomes a lot* of work.

Yeah there is a point, it's so I don't have to run two instances of the same program and rather it's a lot of work or not is up to erengy not you, I currently use both MAL and formally HB (now Kitsu) at the same time so having two separate apps would be great.
You also can only use one service at a time and switching services causes data loss to the service you was using.

@crse
Copy link

crse commented Dec 13, 2016

I agree with Shaun. I believe two different edition of Taiga will help us to update our library fastly.

@sachaw
Copy link

sachaw commented Dec 13, 2016

Sorry @ShaunV2 thought you meant use two instances because you don't use either MAL or Kitsu, my bad, and i see where your coming from.
A better approach I think, is to have better syncing across both platforms.

@ShaunV2
Copy link

ShaunV2 commented Dec 13, 2016

@sachaw I do run two instances of Taiga and I have them both run at startup as well by creating registry keys in HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run since Taiga doesn't write run registry keys there.

I would love to not have to run two instances of Taiga though.

@ovingiv
Copy link

ovingiv commented Dec 14, 2016

Good evening. I am unable to sync my Kitsu account with "TaigaSetup-v1.2.5-25-g2dfd816-kitsu" build. Trying to sync my data it freezes and then it becomes unresponsive.

@erengy
Copy link
Owner Author

erengy commented Dec 14, 2016

Is there anyway you could make two versions of Taiga to support the services separately?

This is most likely never going to happen, for various reasons. The plan is to eventually make a single instance of Taiga synchronize multiple services at the same time (there's an FAQ entry for why this is not the case yet). Anyway, this should be a separate discussion.

Good evening. I am unable to sync my Kitsu account with "TaigaSetup-v1.2.5-25-g2dfd816-kitsu" build. Trying to sync my data it freezes and then it becomes unresponsive.

Hi there @ovingiv. As I said in my previous post, it's not in a usable state yet. I'm not finished implementing all the new API endpoints, and there are a couple of other things to take care of as well. I'd suggest you to wait until I increment the version to 1.2.6-beta (or 1.3.0-beta, I haven't decided yet).

@ovingiv
Copy link

ovingiv commented Dec 14, 2016

@erengy ok no problem...

@ShaunV2
Copy link

ShaunV2 commented Dec 14, 2016

Fair enough @erengy and I look forward for when:

The plan is to eventually make a single instance of Taiga synchronize multiple services at the same time

becomes possible.

@littleladyred
Copy link

Posting to ask how that kitsu update is coming along :)

@erengy
Copy link
Owner Author

erengy commented Dec 21, 2016

I've been working on Taiga pretty much every day for a while now, and it's almost done. Everything except for Seasons page seems to be working. I'll post another comment here in a day or two, after handling that.

@erengy
Copy link
Owner Author

erengy commented Dec 22, 2016

Barring potential errors that I missed, Taiga now supports Kitsu the same way it supported Hummingbird.

I've merged the kitsu branch into develop and bumped the version to 1.3.0-alpha. I'll release an official installer once I bump it to 1.3.0-beta. In the meantime, you may try out the latest build. Just be aware that it may be unstable.

If you install it over a previous installation that used Hummingbird as its active service, Taiga will automatically import all local Hummingbird data and switch the active service to Kitsu. All communications with Kitsu should work as expected. Although, if you have a large library, note that Kitsu's server may take more than 10 seconds to respond in some cases.

Now I need to decide on how to proceed from here. There were lots of other things that I wanted to do for v1.3, including some architectural changes. But it might be a better idea to postpone those for a while and release a stable version with Kitsu support as soon as possible.

@PhiZero
Copy link
Contributor

PhiZero commented Dec 23, 2016

Don't wanna open a new issue for this since it's an alpha build, but I'm unable to sync with Kitsu.
I get "Update failed: Kitsu returned an error: Unknown error (kitsu|9|404).

@erengy
Copy link
Owner Author

erengy commented Dec 23, 2016

It seems that Taiga's trying to update a library entry of yours, but Kitsu says that it doesn't exist.

Did you have some queued updates before upgrading to the alpha build? In any case, try this:

  1. Close Taiga.
  2. Go to Taiga\data\user\{username}@kitsu\ directory and rename history.xml to something like history2.xml.
  3. Run Taiga, hit Synchronize to download your list. When it's done, close Taiga again.
  4. Rename that file back to history.xml.

I'll try to fix this issue tomorrow and update the latest build afterwards. Edit: Done.

@PhiZero
Copy link
Contributor

PhiZero commented Dec 23, 2016

That indeed was the issue and the fix. Thanks!

@robflop
Copy link

robflop commented Dec 26, 2016

Quick question: Will the history get wiped once the update for kitsu compatibility comes out? I have like 40 episodes queued up in the history right now.

@sachaw
Copy link

sachaw commented Dec 26, 2016

@robflop No,its fine, if you download the latest build http://taiga.moe/latest.html and replace it worth your existing taiga.exe in %appdata%/Taiga/Taiga.exe and open it, It'l update your list, If u want to be super careful backup your Taiga directory

@erengy
Copy link
Owner Author

erengy commented Dec 26, 2016

Taiga will import all your local Hummingbird data, so that you don't lose anything. Queued updates will be sent to Kitsu when you synchronize. Unless you've manually added/deleted the same anime via the website too, you shouldn't have any issues. But if you do, let me know!

To explain what happened above with @KazukiMutou: Unlike Hummingbird, Kitsu requires unique IDs to update your library entries. Taiga didn't know these numbers at first and it was sending empty IDs to Kitsu. So I suggested using a trick to force Taiga into downloading the library first, before trying to update it. Since then, I fixed this issue in ad14627 and updated the latest build.

@mynameisnotjake
Copy link

Just downloaded. Getting an error where it says
"Update failed
Title: Shokugeki no Souma Ni no Sara
Reason: Kitsu returned an error" "must be greater than 0: rating - must be greater than 0"

No clue why it's only the second season of Shokugeki, guess that's why this is here.
screenshot_11

@erengy
Copy link
Owner Author

erengy commented Jan 6, 2017

Hi there Jake. I fixed that issue in eb2c4a7, but had not updated the latest build since then. It should be okay if you get the latest latest build now. :)

@mynameisnotjake
Copy link

Tyty

@wopian
Copy link
Contributor

wopian commented Jan 8, 2017

Getting Kitsu returned an error: Unknown error (kitsu|8|503) when updating my library on latest build.

@erengy
Copy link
Owner Author

erengy commented Jan 8, 2017

That 8 is RequestType::kGetLibraryEntries, so Taiga is trying to download your library. I'm getting the same error for yours, while it works for mine. How many library entries do you have? It seems that the server is unable to respond to Taiga's request and it times out after 30 seconds.

@wopian
Copy link
Contributor

wopian commented Jan 8, 2017

Over 3000 entries. 😉

@erengy
Copy link
Owner Author

erengy commented Jan 8, 2017

Yeah, that would do it. If the upcoming API changes don't provide much performance benefits, I'll try to make Taiga get your library in chunks rather than requesting to receive it all in a single response.

@lordage
Copy link

lordage commented Jan 16, 2017

that explains it then 👍 for me just imported my old MAL list and just got this error

@littleladyred
Copy link

Since it's almost been a month since I last posted I have come again to bother you for an update on a beta or official update for kitsu 🦊

@ShaunV2
Copy link

ShaunV2 commented Jan 19, 2017

@littleladyred There is already a beta version available to download, refer to this comment.

I'm using that build now and other then some errors (sometimes you get an error when it tries to sync at startup) it works great.

@littleladyred
Copy link

@ShaunV2 That's an alpha version. I am using it at the moment. I was asking for an official beta, stable installer release. That a bit more specific?

@ShaunV2
Copy link

ShaunV2 commented Jan 19, 2017

@littleladyred Fair enough.

I'm sure he will mention when an official beta or stable installer will be released.

@erengy
Copy link
Owner Author

erengy commented Jan 21, 2017

Since it's almost been a month since I last posted I have come again to bother you for an update on a beta or official update for kitsu 🦊

Kitsu's API is not stable enough for me to release a stable version yet. I could release a beta version with an actual installer, but I'm trying to use this opportunity to get #316 done first, which is going to take a while.

@auyongcheemeng
Copy link

auyongcheemeng commented Feb 18, 2017

http://taiga.moe/latest.html

The latest build of 1.3.0-alpha as of today (18/2/2017 UTC) triggers a malware detection in Windows Defender as Trojan:Win32/Detplock


File details:
SHA256: ca356cb8b33a6a8f0aaf7b8d570e2ac4853f308998d7065bfa860f2888258216
Size: 2.1 MB ( 2235904 bytes )


False positive?

@navarr
Copy link

navarr commented Feb 18, 2017

@auyongcheemeng Could you ensure that your virus definitions in Windows Defender are up to date?

A quick Google search shows there was a similar problem with Hearthstone for a bit with out of date definitions.

@auyongcheemeng
Copy link

auyongcheemeng commented Feb 18, 2017

Yes they are (on 18/2/2017 2.58AM - v 1.235.3101.0), as of this moment.

PS: This month's windows updates got delayed. I'll hold on for a bit more till next definition updates.

@wopian
Copy link
Contributor

wopian commented Feb 18, 2017

And seriously use a better antivirus as Windows Defender is terrible.

That may have been the case in the pre-windows 8 era, but Defender is pretty competent for common user nowadays.

Also better of in #19

@auyongcheemeng
Copy link

auyongcheemeng commented Feb 20, 2017

As an update: definations got updated and taiga (SHA256: ca356c...258216) no longer triggers the false positive.

A side note on ShaunV2's comment: Using any third party security software will increase the attack surface of threats

@navarr
Copy link

navarr commented Feb 20, 2017

Let's keep the arguments about anti-virus off this thread, it's unproductive.

@pervertkirito
Copy link

is it died?

@hagamablabla
Copy link

Still works for me.

@ghost
Copy link

ghost commented May 15, 2017

If anyone wants to use their Kitsu library right now, you can use Kitsu's export functions and live-export (change on Kitsu and auto-update on MAL) to MAL and use that for now

@wopian
Copy link
Contributor

wopian commented May 15, 2017

Or you can use 1.3.0 alpha and update Kitsu normally...

@erengy
Copy link
Owner Author

erengy commented Sep 20, 2017

v1.3.0-beta is now available:
https://github.com/erengy/taiga/releases/tag/v1.3.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests