Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect confusable nicks during database import #1439

Closed
slingamn opened this issue Dec 7, 2020 · 1 comment
Closed

detect confusable nicks during database import #1439

slingamn opened this issue Dec 7, 2020 · 1 comment
Labels
release blocker Blocks release
Milestone
v2.5

Comments

@slingamn
Copy link
Member

slingamn commented Dec 7, 2020

If we import records for, e.g., bob and b0b, the lexicographically first entry (in this case b0b) will be unusable because of a skeleton conflict.

We should detect this and warn about it at import time. We can suggest that the operator configure casemapping: ascii to prevent the conflict.
@slingamn slingamn added the release blocker Blocks release label Dec 7, 2020
@slingamn slingamn added this to the v2.5 milestone Dec 7, 2020
@slingamn
Copy link
Member Author

slingamn commented Dec 7, 2020

I actually tested this and for authenticated users, force-nick-equals-account (or always-on) bypasses the code path that checks nick reservations (sensibly so). So being lexicographically first is irrelevant. The first user to connect will get through, and the second won't.

slingamn added a commit that referenced this issue Dec 8, 2020
@slingamn
Merge pull request #1444 from slingamn/issue1439_confusable_import
85c39f3 
fix #1439, give all atheme group founders +q
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release blocker Blocks release
Projects
None yet
Milestone
v2.5
Development

No branches or pull requests
1 participant
@slingamn