Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool performance #17

Closed
catena2w opened this issue Aug 15, 2017 · 6 comments
Closed

mempool performance #17

catena2w opened this issue Aug 15, 2017 · 6 comments
Assignees
Labels
C-bug Category: This is a bug C-question Category: Question

Comments

@catena2w
Copy link
Member

Check mempool performance and uncomment performance tests

@catena2w catena2w added this to the testnet-0 milestone Aug 15, 2017
@catena2w catena2w added the C-bug Category: This is a bug label Aug 15, 2017
@terjokhin terjokhin self-assigned this Mar 22, 2018
@terjokhin
Copy link
Contributor

@catena2w Is it still an issue? Cause looks like on my local machine this tests pass like a charm.

@terjokhin terjokhin added the C-question Category: Question label Mar 22, 2018
@terjokhin
Copy link
Contributor

Also I found this wonderful library https://github.com/blemale/scaffeine, so we can use it to implement mempool with caffeine cache library.

@Tolsi
Copy link
Contributor

Tolsi commented Mar 23, 2018 via email

@terjokhin
Copy link
Contributor

Anyway it won't fit our needs cause there is no 'filter' operations with cache.

@ben-manes
Copy link

Can you explain what you mean by filter? (There is the asMap() view if that helps)

Most workloads are not heavily recency-skewed, which the cache underperforms by a small margin. We have a conference paper under review for making it adaptive, which corrects for this flaw. Afterwards, I hope to integrate the research into Caffeine.

@catena2w
Copy link
Member Author

catena2w commented Aug 1, 2018

replaced by #391

@catena2w catena2w closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug C-question Category: Question
Projects
None yet
Development

No branches or pull requests

4 participants