Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibilty fix and parent names #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Accessibilty fix and parent names #60

wants to merge 2 commits into from

Conversation

mikaelgu80
Copy link

I've:

  1. added names to the checkboxes so prevent accessibilty checks from complaining
  2. added a new option to include parent names to getSelectedNames.

@mikaelgu80
Accessibility fix
58db912 
Add name attribute to checkboxes. sourceItem.title is used as the name. This stops browser's accessibilty checks from complaining about the checkboxes.
@mikaelgu80
Hierarchical names
4b0d6eb 
Add option to include the names of the parents to getSelectedNames. The names of the parents are joined by ' - ' and prepended to the name of the selected item, separated by '; '.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mikaelgu80