Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compatibility for the later version pytorch #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GongXinyuu
Copy link

In the original implementation, an error will occur "RuntimeError: A view was created in no_grad mode and is being modified inplace with grad mode enabled" using PyTorch 1.8.

In the original implementation, an error will occur "RuntimeError: A view was created in no_grad mode and is being modified inplace with grad mode enabled" using PyTorch 1.8.
@eric8607242
Copy link
Owner

eric8607242 commented Apr 4, 2021

Thanks for the pull request!
To make sure the gradient flow and update the architecture generator, I think that the architecture parameter may not be detached in line 222 of lookup_table_builder.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants