This repository has been archived by the owner on Jan 21, 2024. It is now read-only.
Only run tests that need a running DS9 if display is set #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only likely to be useful for testing on CI platforms and there is an issue with the DISPLAY setting. It is UNIX specific, so needs re-thinking for Windows platforms.
This helps out on tests that would otherwise hang for ever (or at least they appear to have a very-long time out). It is UNIX-specific, and needs thinking about whether it's worth something similar for Windows systems.
DougBurke
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests which are known to hang the system are only run if the DISPLAY environment variable is set. The idea is to be a bit-more helpful on potentially-problematic systems (e.g. the recent test failures due to time outs on Travis which I believe was to do with the xvfb-created display, but it's not clear that this would have actually avoided that problem).
Issues
Addresses #91 - but I'm not convinced it's worth it at this time.