fix: Update usage of StatsigServerOptions (open-feature#169)

Signed-off-by: Jens Henneberg <[email protected]>
ericpattison · Apr 3, 2024 · d12bbc7 · d12bbc7
1 parent f5c80e9
commit d12bbc7
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/src/OpenFeature.Contrib.Providers.Statsig/EvaluationContextExtensions.cs b/src/OpenFeature.Contrib.Providers.Statsig/EvaluationContextExtensions.cs
@@ -5,7 +5,7 @@ namespace OpenFeature.Contrib.Providers.Statsig
 {
     internal static class EvaluationContextExtensions
     {
-        //These keys match the keys of the statsiguser object as descibed here
+        //These keys match the keys of the statsiguser object as described here
         //https://docs.statsig.com/client/concepts/user
         internal const string CONTEXT_APP_VERSION = "appVersion";
         internal const string CONTEXT_COUNTRY = "country";

diff --git a/src/OpenFeature.Contrib.Providers.Statsig/README.md b/src/OpenFeature.Contrib.Providers.Statsig/README.md
@@ -10,32 +10,32 @@ The first things we will do is install the **Open Feature SDK** and the **Statsi
 
 ### .NET Cli
 ```shell
-dotnet add package OpenFeature.Contrib.Providers.Statsig
+dotnet add package OpenFeature.Contrib.Provider.Statsig
 ```
 ### Package Manager
 
 ```shell
-NuGet\Install-Package OpenFeature.Contrib.Providers.Statsig
+NuGet\Install-Package OpenFeature.Contrib.Provider.Statsig
 ```
 ### Package Reference
 
 ```xml
-<PackageReference Include="OpenFeature.Contrib.Providers.Statsig" />
+<PackageReference Include=" OpenFeature.Contrib.Provider.Statsig" />
 ```
 ### Packet cli
 
 ```shell
-paket add OpenFeature.Contrib.Providers.Statsig
+paket add OpenFeature.Contrib.Provider.Statsig
 ```
 
 ### Cake
 
 ```shell
-// Install OpenFeature.Contrib.Providers.Statsig as a Cake Addin
-#addin nuget:?package=OpenFeature.Contrib.Providers.Statsig
+// Install OpenFeature.Contrib.Provider.Statsig as a Cake Addin
+#addin nuget:?package= OpenFeature.Contrib.Provider.Statsig
 
-// Install OpenFeature.Contrib.Providers.Statsig as a Cake Tool
-#tool nuget:?package=OpenFeature.Contrib.Providers.Statsig
+// Install OpenFeature.Contrib.Provider.Statsig as a Cake Tool
+#tool nuget:?package= OpenFeature.Contrib.Provider.Statsig
 ```
 
 ## Using the Statsig Provider with the OpenFeature SDK
@@ -44,7 +44,7 @@ The following example shows how to use the Statsig provider with the OpenFeature
 
 ```csharp
 using OpenFeature;
-using OpenFeature.Contrib.Providers.Statsig;
+using OpenFeature.Contrib.Provider.Statsig;
 using System;
 
 StatsigProvider statsigProvider = new StatsigProvider("#YOUR-SDK-KEY#");

diff --git a/src/OpenFeature.Contrib.Providers.Statsig/StatsigProvider.cs b/src/OpenFeature.Contrib.Providers.Statsig/StatsigProvider.cs
@@ -24,23 +24,20 @@ public sealed class StatsigProvider : FeatureProvider
         volatile bool initialized = false;
         private readonly Metadata _providerMetadata = new Metadata("Statsig provider");
         private readonly string _sdkKey = "secret-"; //Dummy sdk key that works with local mode
-        private readonly StatsigServerOptions _options;
         internal readonly ServerDriver ServerDriver;
 
         /// <summary>
         /// Creates new instance of <see cref="StatsigProvider"/>
         /// </summary>
         /// <param name="sdkKey">SDK Key to access Statsig.</param>
-        /// <param name="configurationAction">The action used to configure the client.</param>
-        public StatsigProvider(string sdkKey = null, Action<StatsigServerOptions> configurationAction = null)
+        /// <param name="statsigServerOptions">The StatsigServerOptions to configure the provider.</param>
+        public StatsigProvider(string sdkKey = null, StatsigServerOptions statsigServerOptions = null)
         {
             if (sdkKey != null)
             {
                 _sdkKey = sdkKey;
             }
-            _options = new StatsigServerOptions();
-            configurationAction?.Invoke(_options);
-            ServerDriver = new ServerDriver(_sdkKey, _options);
+            ServerDriver = new ServerDriver(_sdkKey, statsigServerOptions);
         }
 
         /// <inheritdoc/>

diff --git a/test/OpenFeature.Contrib.Providers.Statsig.Test/StatsigProviderTest.cs b/test/OpenFeature.Contrib.Providers.Statsig.Test/StatsigProviderTest.cs
@@ -4,6 +4,7 @@
 using OpenFeature.Model;
 using System.Threading.Tasks;
 using Xunit;
+using Statsig;
 namespace OpenFeature.Contrib.Providers.Statsig.Test;
 
 public class StatsigProviderTest
@@ -12,7 +13,7 @@ public class StatsigProviderTest
 
     public StatsigProviderTest()
     {
-        statsigProvider = new StatsigProvider("secret-", x => x.LocalMode = true);
+        statsigProvider = new StatsigProvider("secret-", new StatsigServerOptions() { LocalMode = true });
     }
 
     [Fact]