Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a way to create a utf8z from a ReadOnlySpan<byte> #399

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Expose a way to create a utf8z from a ReadOnlySpan<byte> #399

merged 2 commits into from
Feb 3, 2021

Conversation

CyrusNajmabadi
Copy link
Contributor

No description provided.

@CyrusNajmabadi
Copy link
Contributor Author

@ericsink I'm also thinking about exposing util.to_utf8_with_z as a static method off of utf8z (with a more appropriate .net name). Basically, it would just ensure that clients of the library agree with the library on exactly how a string should be encoded to be valid for you.

Would that be ok with you?

@CyrusNajmabadi
Copy link
Contributor Author

@ericsink ?

@ericsink
Copy link
Owner

ericsink commented Feb 3, 2021

Yeah, stand by, I'm trying to catch up with this. :-)

@ericsink
Copy link
Owner

ericsink commented Feb 3, 2021

LGTM. In fact, you've gone rather above and beyond the call of duty here with the API comments, thanks.

The util.to_utf8_with_z change you mentioned would be fine too. Should I merge this PR now or wait for that piece?

@CyrusNajmabadi
Copy link
Contributor Author

I'll add that piece.

@CyrusNajmabadi
Copy link
Contributor Author

@ericsink ready.

@ericsink ericsink merged commit 3c6f89d into ericsink:master Feb 3, 2021
ericsink added a commit that referenced this pull request Feb 9, 2021
@ericsink
rename to utf8z.GetZeroTerminatedUTF8Bytes() and add a simple test ca…
fcddb4b 
…se for it. #399
@ericsink ericsink mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsink ericsink ericsink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyrusNajmabadi @ericsink