Skip to content

Commit

Permalink
silkworm: disable on incompatible Linux versions (#8893)
Browse files Browse the repository at this point in the history
Silkworm built on Ubuntu 22 depends on glibc 2.34. In order to run on an
older OS, Silkworm needs to be built and linked with an older glibc, but
to build on an older OS we need a compatible compiler. Silkworm requires
gcc 11+ that is not available on Ubuntu 20 or Debian 11.

To simplify the deployment disable Silkworm support on versions before
Ubuntu 22, Debian 12, and glibc prior to 2.34. The check for Ubuntu and
Debian is explicit, because some Ubuntu 16 installations report glibc
2.35 with ldd, but `go build` still uses an older system one and fails.
  • Loading branch information
battlmonstr authored and awskii committed Dec 6, 2023
1 parent a25f9b5 commit be8604b
Show file tree
Hide file tree
Showing 2 changed files with 74 additions and 0 deletions.
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ CGO_CFLAGS += -Wno-unknown-warning-option -Wno-enum-int-mismatch -Wno-strict-pro

# about netgo see: https://github.com/golang/go/issues/30310#issuecomment-471669125 and https://github.com/golang/go/issues/57757
BUILD_TAGS = nosqlite,noboltdb

ifneq ($(shell "$(CURDIR)/turbo/silkworm/silkworm_compat_check.sh"),)
BUILD_TAGS := "$(BUILD_TAGS),nosilkworm"
endif

PACKAGE = github.com/ledgerwatch/erigon

GO_FLAGS += -trimpath -tags $(BUILD_TAGS) -buildvcs=false
Expand Down
69 changes: 69 additions & 0 deletions turbo/silkworm/silkworm_compat_check.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
#!/bin/bash

set -e
set -u
set -o pipefail

OS_RELEASE_PATH=/etc/os-release

function glibc_version {
cmd="ldd --version"
$cmd | head -1 | awk '{ print $NF }'
}

function version_major {
IFS='.' read -a components <<< "$1"
echo "${components[0]}"
}

function version_minor {
IFS='.' read -a components <<< "$1"
echo "${components[1]}"
}

case $(uname -s) in
Linux)
if [[ ! -f "$OS_RELEASE_PATH" ]]
then
echo "not supported Linux without $OS_RELEASE_PATH"
exit 2
fi

source "$OS_RELEASE_PATH"

if [[ -n "$ID" ]] && [[ -n "$VERSION_ID" ]]
then
version=$(version_major "$VERSION_ID")
case "$ID" in
"debian")
if (( version < 12 ))
then
echo "not supported Linux version: $ID $VERSION_ID"
exit 3
fi
;;
"ubuntu")
if (( version < 22 ))
then
echo "not supported Linux version: $ID $VERSION_ID"
exit 3
fi
;;
esac
fi

version=$(version_minor "$(glibc_version)")
if (( version < 34 ))
then
echo "not supported glibc version: $version"
exit 4
fi

;;
Darwin)
;;
*)
echo "unsupported OS"
exit 1
;;
esac

0 comments on commit be8604b

Please sign in to comment.