Use the same data type as go-ethereum in the stateDiff override for eth_call #10531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it was some perf change: #575 |
|
For additional context, does this fix #8345? |
AskAlexSharov
approved these changes
Jul 27, 2024
AskAlexSharov
pushed a commit
that referenced
this pull request
Jul 27, 2024
…th_call (#10531) Change the datatype used for the "stateDiff" override to eth_call to a hash instead of a uint256. https://github.com/ethereum/go-ethereum/blob/171430c3f5d474327bc1721c7c36ad83ad21b4b2/internal/ethapi/api.go#L975-L976
This was referenced Jul 27, 2024
AskAlexSharov
added a commit
that referenced
this pull request
Jul 27, 2024
cherry pick of #10531 Co-authored-by: boyuan-chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the datatype used for the "stateDiff" override to eth_call to a hash instead of a uint256.
https://github.com/ethereum/go-ethereum/blob/171430c3f5d474327bc1721c7c36ad83ad21b4b2/internal/ethapi/api.go#L975-L976