Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI (#3779): pass docker build arguments on Docker Hub #4252

Merged
merged 1 commit into from
May 25, 2022
Merged

CI (#3779): pass docker build arguments on Docker Hub #4252

merged 1 commit into from
May 25, 2022

Conversation

battlmonstr
Copy link
Contributor

see discussion in #4239

@AskAlexSharov AskAlexSharov marked this pull request as ready for review May 24, 2022 15:31
@battlmonstr battlmonstr marked this pull request as draft May 24, 2022 17:04
@battlmonstr battlmonstr marked this pull request as ready for review May 24, 2022 19:08
@battlmonstr
Copy link
Contributor Author

battlmonstr commented May 24, 2022 •
edited
Loading

Note: GIT_TAG redefenition is needed, because in the hook the GIT_TAG variable was predefined to <commit sha> by git/dockerhub, and this value was unexpectedly accepted in the Makefile as the default.

@AskAlexSharov AskAlexSharov merged commit 0d25938 into devel May 25, 2022
@AskAlexSharov AskAlexSharov deleted the docker_makegittag2 branch May 25, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AskAlexSharov AskAlexSharov AskAlexSharov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@battlmonstr @AskAlexSharov