tests: test that erigon can be used as a library #8494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/erigon_ext_test
branch
from
cad8f11
to
e6c52e1
Compare
battlmonstr
force-pushed
the
pr/erigon_ext_test
branch
from
e6c52e1
to
8ea97ae
Compare
There was a problem hiding this comment.
if this lint message is annoying - can add //nolint to the line, or exclude folder in .golangci.yml
There was a problem hiding this comment.
This seems to be coming from go test ./... which tries to run this as a unit test. GitHub is so smart now that it shows this error in line? (so it looks like a linter problem) I'm trying to fix now by adding a dummy go.mod.
AskAlexSharov
approved these changes
Nov 1, 2023
battlmonstr
force-pushed
the
pr/erigon_ext_test
branch
from
fcc4f82
to
28c3486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.