Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable h2c for http handler. add https handler for http2 #8610

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Conversation

elee1766
Copy link
Contributor

@elee1766 elee1766 commented Oct 30, 2023

new flag examples.

--https.enabled
--https.addr="0.0.0.0"
--https.port=443
--https.url="unix:///file.wow"
--https.cert="keyfile.cert"
--https.key="certfile.cert"

also adds support for h2c to the http handler - http2 protocol without tls.

@elee1766
Copy link
Contributor Author

elee1766 commented Oct 30, 2023

@AskAlexSharov is this panic in windows ci caused by this pr ? seems unrelated.

--- FAIL: TestProviderFuncRegistration (4.00s)
panic: close of closed channel [recovered]
	panic: close of closed channel

goroutine 8 [running]:
testing.tRunner.func1.2({0xfa7e00, 0xffccc0})
	testing/testing.go:1526 +0x24e
testing.tRunner.func1()
	testing/testing.go:1529 +0x39f
panic({0xfa7e00, 0xffccc0})
	runtime/panic.go:884 +0x213
github.com/ledgerwatch/erigon-lib/diagnostics.Context[...].func1()
	github.com/ledgerwatch/erigon-lib/diagnostics/provider.go:126 +0x26
github.com/ledgerwatch/erigon-lib/diagnostics_test.TestProviderFuncRegistration(0xc00003d6c0?)
	github.com/ledgerwatch/erigon-lib/diagnostics/provider_test.go:84 +0x184
testing.tRunner(0xc00003dba0, 0xfd6680)
	testing/testing.go:1576 +0x10b
created by testing.(*T).Run
	testing/testing.go:1629 +0x3ea

@AskAlexSharov
Copy link
Collaborator

i don't know - probably not

@elee1766 elee1766 merged commit d8d7d8d into devel Oct 31, 2023
7 checks passed
@elee1766 elee1766 deleted the http2 branch October 31, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants