metrics: switch to using prometheus library #8741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgelb
pushed a commit
to bgelb/erigon
that referenced
this pull request
Nov 17, 2023
# Background Erigon currently uses a combination of Victoria Metrics and Prometheus client for providing metrics. We want to rationalize this and use only the Prometheus client library, but we want to maintain the simplified Victoria Metrics methods for constructing metrics. This task is currently partly complete and needs to be finished to a stage where we can remove the Victoria Metrics module from the Erigon code base. ## Tests ### Functional * Make sure that the format change int->float implied by VM to Prometheus does not impact clients (pay particular attention to block numbers) * Check that the prometheus/grafana dashboards defined in cmd/prometheus are functional after the change (see docker-compose.yml for details and https://github.com/ledgerwatch/erigon/tree/devel/cmd/prometheus#readme) * Confirm that the underlying go metrics are still generated * Confirm the following flags setting work: --metrics, --metrics.addr, --metrics.port with the new code * Confirm that --metrics and --proff settings and handlers configuration still allow metrics and pprof to share a port #### Float counters - scientific notation test case   #### Float counters - NaN test case   ### Performance * Check the performance of counters created by RPC calls measurements created by rpc/metrics.go are not impacted by the change. #### RPC Performed tests on rpcdaemon & erigon on localhost using `etc_blockNumber`. Did tests with 100, 1000, 10000 requests. Got a steady 15 ms response time. #### Memory 
bgelb
pushed a commit
to bgelb/erigon
that referenced
this pull request
Nov 18, 2023
# Background Erigon currently uses a combination of Victoria Metrics and Prometheus client for providing metrics. We want to rationalize this and use only the Prometheus client library, but we want to maintain the simplified Victoria Metrics methods for constructing metrics. This task is currently partly complete and needs to be finished to a stage where we can remove the Victoria Metrics module from the Erigon code base. ## Tests ### Functional * Make sure that the format change int->float implied by VM to Prometheus does not impact clients (pay particular attention to block numbers) * Check that the prometheus/grafana dashboards defined in cmd/prometheus are functional after the change (see docker-compose.yml for details and https://github.com/ledgerwatch/erigon/tree/devel/cmd/prometheus#readme) * Confirm that the underlying go metrics are still generated * Confirm the following flags setting work: --metrics, --metrics.addr, --metrics.port with the new code * Confirm that --metrics and --proff settings and handlers configuration still allow metrics and pprof to share a port #### Float counters - scientific notation test case   #### Float counters - NaN test case   ### Performance * Check the performance of counters created by RPC calls measurements created by rpc/metrics.go are not impacted by the change. #### RPC Performed tests on rpcdaemon & erigon on localhost using `etc_blockNumber`. Did tests with 100, 1000, 10000 requests. Got a steady 15 ms response time. #### Memory 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Erigon currently uses a combination of Victoria Metrics and Prometheus client for providing metrics.
We want to rationalize this and use only the Prometheus client library, but we want to maintain the simplified Victoria Metrics methods for constructing metrics.
This task is currently partly complete and needs to be finished to a stage where we can remove the Victoria Metrics module from the Erigon code base.
Tests
Functional
(see docker-compose.yml for details and https://github.com/ledgerwatch/erigon/tree/devel/cmd/prometheus#readme)
--metrics, --metrics.addr, --metrics.port with the new code
Float counters - scientific notation test case
Float counters - NaN test case
Performance
RPC
Performed tests on rpcdaemon & erigon on localhost using
etc_blockNumber.Did tests with 100, 1000, 10000 requests. Got a steady 15 ms response time.
Memory