FIx outstanding know header==nil errors + reduce bor heimdall logging #8878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixes for a number of instances in the bor heimdall stage where nil headers are either ignored or inadvertently processed.
It also has a demotion of milestone related logging messages to debug for missing blocks because the process is not at the head of the chain + a general reduction in periodic logging to 30 secs rather than 20 to reduce the log output on long runs.
In addition there is a refactor of persistValidatorSets to perform validator set initiation in a seperate function. This is intended to clarify the operation of persistValidatorSets - which is till performing 2 actions, persisting the snapshot and then using it to check the header against synthesized validator set in the snapshot.