-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
borheimdall: only fetch next span when in last sprint of current span #9096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One style comment I think we should discuss.
In the codebase both ID and Id are used to refer to span indentifiers
My preference would be to use Id, as ID is not used across the erigon codebase in general.
ok, happy with any of the 3 options - we would need to chat with @battlmonstr too |
follow up on naming as suggested here #9096 (review)
Corresponds to the client fix in this PR description - #9096 (comment)
Heimdall prepares the next span a number of sprints before the current span ends. Currently we always fetch the next span regardless of which sprint we are in during the current span. This causes a liveness issue due to how the Heimdall client works (it infinitely retries until it fetches a span - this issue will be fixed in a separate PR). This PR fixes this by matching what bor does - it fetches the next span only in the last sprint of the current span.
Changes: