Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloader: calling wrong url to download .torrent #9867

Merged
merged 3 commits into from
Apr 7, 2024
Merged

downloader: calling wrong url to download .torrent #9867

merged 3 commits into from
Apr 7, 2024

Conversation

AskAlexSharov
Copy link
Collaborator

@AskAlexSharov AskAlexSharov commented Apr 5, 2024 •
edited
Loading

  • new method DownloadAndSaveTorrentFile did download data files instead of .torrent files because WebSeeds.ByName() return data urls - not .torrent urls
  • calling wrong url to download .torrent
  • save value to disk without .torrent suffix
  • size attack prevention - did return nil err and it stopped webseed scanning

@AskAlexSharov AskAlexSharov requested a review from mh0lt April 5, 2024 16:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AskAlexSharov AskAlexSharov merged commit fbe3a46 into devel Apr 7, 2024
7 checks passed
@AskAlexSharov AskAlexSharov deleted the down_wrong_url_use branch April 7, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awskii awskii awskii approved these changes

@mh0lt mh0lt Awaiting requested review from mh0lt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AskAlexSharov @awskii