Caplin: Fixed archive node validator set lists. #9886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giulio2002
force-pushed
the
fix-archive-cl
branch
from
482cba7
to
501686b
Compare
Giulio2002
changed the title
Giulio2002
force-pushed
the
fix-archive-cl
branch
from
bdce539
to
f0a384c
Compare
domiwei
reviewed
Apr 9, 2024
| @@ -230,7 +275,7 @@ func (s *StaticValidatorTable) AddValidator(v solid.Validator, validatorIndex, s | |||
| return nil | |||
| } | |||
| s.validatorTable = append(s.validatorTable, NewStaticValidatorFromValidator(v, slot)) | |||
| if validatorIndex >= uint64(len(s.validatorTable)) { | |||
| if validatorIndex != uint64(len(s.validatorTable))-1 { | |||
There was a problem hiding this comment.
Can't we remove this param validatorIndex?
domiwei
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically we keep the history of somewhat static fields in memory of our validatorset (this is cheap). however when restarting the node and reading these static fields, we do not reset them to the closes valid slot for incremental processing