Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS support back to podspec #540

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Saadnajmi
Copy link

Cocoapods fully supports visionOS (which seemed to be why #532 had to revert the support), so let's add this back.

@erikdoe
Copy link
Owner

erikdoe commented May 17, 2024

Thank you for bringing this up. That said, OCMock supports multiple package managers, and to “add visionOS support” it’s not sufficient to add it to the podspec only. If you want to increase the chance of this PR getting merged quickly, please includes changes for the other package managers, too.

@Saadnajmi
Copy link
Author

@erikdoe Looking into it, it seems SPM should have visionOS support already, as I don't see a platforms filter in the Package.swift (so I assume it targets all platforms)? I can't tell for Carthage.. I think I'll need to update the pbxproj to have visionOS as a destination perhaps?

@erikdoe
Copy link
Owner

erikdoe commented May 27, 2024

In order for this to progress, it looks like we need to resolve an issue with CocoaPods. For #537 I made a release yesterday, but I can't seem to push this release due to an error with CocoaPods:

➜  ocmock git:(master) pod trunk push --allow-warnings

[!] Found podspec `OCMock.podspec`
Updating spec repo `trunk`
[!] CDN: trunk URL couldn't be downloaded: https://cdn.cocoapods.org/deprecated_podspecs.txt Response: URL using bad/illegal format or missing URL

If I were to merge this PR and make a release with visionOS support, I assume I'd be running into the same problem. Anyone know what to do?

@erikdoe
Copy link
Owner

erikdoe commented Jun 30, 2024

In the meantime I have resolved the problem with CocoaPods. So I could publish a pod with visionOS support. However we still need to add visionOS support for the other build styles.

@Saadnajmi As far as I can tell, you'd have to add a visionOS specific target to the Xcode project. Similar to how this is done for watchOS and tvOS.

@Saadnajmi
Copy link
Author

@erikdoe Sounds good! I'll try to take a look this week. @okwasniewski fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants