Fix IE11 'findIndex' error #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 96.2% 96.47% +0.26%
==========================================
Files 4 4
Lines 79 85 +6
==========================================
+ Hits 76 82 +6
Misses 3 3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 96.2% 96.47% +0.26%
==========================================
Files 4 4
Lines 79 85 +6
==========================================
+ Hits 76 82 +6
Misses 3 3
Continue to review full report at Codecov.
|
franjohn21
commented
Feb 12, 2019
| @@ -1,7 +1,7 @@ | |||
| language: node_js | |||
|
|
|||
| before_install: | |||
| - npm install -g npm@latest | |||
| - npm install -g npm@5 | |||
There was a problem hiding this comment.
The latest version of npm does not work on the earlier versions of Node, hence why I pinned it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
lru-memoizepackage in a browser bundle, it breaks in IE11 due to this package's usage of findIndexThis PR fixes that by using a custom
findIndexfunction that achieves the exact same functionality./review @erikras